gh-125880: Fix exit codes in PyREPL #125890
Conversation
Eclips4
commented
Oct 23, 2024
•
Eclips4
commented
- Issue: Exit codes are lost in the REPL #125880
Eclips4
requested review from
ericsnowcurrently,
pablogsal,
lysnikolaou and
ambv
as code owners
| @@ -101,6 +101,7 @@ pymain_err_print(int *exitcode_p) | |||
| int exitcode; | |||
| if (_Py_HandleSystemExit(&exitcode)) { | |||
| *exitcode_p = exitcode; | |||
| Py_Exit(exitcode); | |||
There was a problem hiding this comment.
This is needed in order to match behavior of PyRUn_AnyFileExFlags(which the old REPL called an still calls if PYTHON_BASIC_REPL=1) which somewhere calls handle_system_exit (Python/pythonrun.c::L632)) which handles SystemExit and calls Py_Exit.
There was a problem hiding this comment.
In that case this path doesn't return as this calls PyFinalize_Ex and then exit()
There was a problem hiding this comment.
As well as previous approach with PyRun_AnyFileExFlags, so, is this a problem?
There was a problem hiding this comment.
Not sure I follow what you mean. Could you clarify ?
There was a problem hiding this comment.
Sorry for not being clear!
I mean, the previous approach with PyRun_AnyFileExFlags contains path with handle_system_exit which is also didn't return as it calls PyFinalizeEx and then exit().
